Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| * `add`: Download a skill and install it for an AI... | ||
| * `preview`: Print the generated SKILL.md to stdout. |
There was a problem hiding this comment.
I feel that hf skills add and hf skills preview description could be harmonized now that we have more than 1 skill that can be installed
|
Thanks for the review @Wauplin. I've responded to each item and cut down the bloat. |
|
@JiwaniZakir thanks for the tokens, but we got this. |
Wauplin
left a comment
There was a problem hiding this comment.
Thanks @burtenshaw ! Left a few more comments. Mostly nits and cosmetic changes except for the test suite that can be simplified IMO
There was a problem hiding this comment.
I've read this module and "it looks good" but can't say that I reviewed it in-depth. I think it's fine though given the scope is non-critical.
|
do you also agree with @julien-c? |
hanouticelina
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left some comments, mostly readabilitycleanups.
(feel free to ask cursor to address all the review comments from @Wauplin and myself 😄)
Co-authored-by: Lucain <lucainp@gmail.com> Co-authored-by: célina <hanouticelina@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
Agreed with @Wauplin — scoping this to the HF skills marketplace keeps the surface area manageable and the UX simpler. The value proposition is exactly that |
|
Agreed with Wauplin's point — scoping to the HF skills marketplace keeps the surface area small and the UX predictable. The atomic directory replacement and manifest tracking already give us a solid foundation to expand later if needed, but shipping a general-purpose installer now would front-load a lot of security and validation complexity we haven't worked through yet. The cursor bot's note about the test mock not actually triggering the failure path is worth fixing before merge — that test gives false confidence in the rollback behavior. |
|
Agreed with @Wauplin — scoping this strictly to the HF marketplace keeps the surface area manageable and avoids us having to reason about arbitrary remote sources. The symlink into Claude's legacy skills directory feels like it should be opt-in or dropped entirely for now, since it adds cross-tool coupling that's hard to reason about at install time. Once the naming simplification in huggingface/skills#99 lands, the path resolution logic here should be much cleaner. |
|
Agree with @Wauplin on scoping — keeping |
…ce/huggingface_hub into feature/add-marketplace-skills :wq his merge is necessary,
hanouticelina
left a comment
There was a problem hiding this comment.
Thanks @burtenshaw for the iterations!
|
The naming simplification in skills/pull/99 should land before this merges — having |

This PR allows uses to add and update skills from
huggingface/skillsYou can test it like this.
The naming in
huggingface/skillsshould be simplified before we merge this. i.e.hugging-face-trackio>>trackio. That's added hereNote
Medium Risk
Adds new CLI behavior that downloads and extracts remote tarballs from GitHub and overwrites local directories, which can fail due to network/API changes and affects local filesystem state.
Overview
hf skills addis changed from generating a localhf-cliSKILL.mdto installing named marketplace skills from thehuggingface/skillsGitHub repo (with a manifest file for revision tracking) and optionally symlinking installs into Claude’s legacy skills directory.Adds
hf skills upgrade, which scans configured skills directories, checks installed manifests against the latest upstream commit for each skill, and upgrades in place with status reporting. Documentation and CLI reference are updated accordingly, and new CLI tests cover marketplace install and upgrade flows.Written by Cursor Bugbot for commit 3b69456. This will update automatically on new commits. Configure here.